Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a couple of linkcheck exceptions: #2120

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

marxin
Copy link
Contributor

@marxin marxin commented Nov 3, 2024

Addresses:


Server returned 500 Internal Server Error for https://github.com/rust-lang/rust/pulls?q=is%3Apr+label%3AS-inactive+is%3Aclosed
Server returned 401 Unauthorized for https://objects.githubusercontent.com/github-production-release-asset-2e65be/343907537/60cd5880-7b81-11eb-9502-68d5f473ebe2?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=releaseassetproduction%2F20241103%2Fus-east-1%2Fs3%2Faws4_request&X-Amz-Date=20241103T085906Z&X-Amz-Expires=300&X-Amz-Signature=e532fd7d2bd271f12988982bc8e5a47a0f966b40452b55d444bbb74292ac1fb1&X-Amz-SignedHeaders=host&response-content-disposition=attachment%3B%20filename%3Drustc.generic.wpaProfile&response-content-type=application%2Foctet-stream
Server returned 500 Internal Server Error for https://github.com/rust-lang/rust/pulls?q=is%3Apr+label%3AS-inactive

@jieyouxu jieyouxu added the S-waiting-on-review Status: this PR is waiting for a reviewer to verify its content label Nov 4, 2024
Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about the PR link exceptions, but I also am not sure about the linkcheck in general... so maybe cc @tshepang and @camelid?

book.toml Outdated Show resolved Hide resolved
@marxin
Copy link
Contributor Author

marxin commented Nov 4, 2024

I'm not sure about the PR link exceptions, but I also am not sure about the linkcheck in general... so maybe cc @tshepang and @camelid?

Note these are the last missing pieces after which the full link check will become green again. Moreover, with mdbook-linkcheck2, we can also enable checking for modified files (with -f option) and should result in more stable links in the future.

@marxin marxin force-pushed the fix-broken-links-part-5 branch 2 times, most recently from f2fd0bb to 919b727 Compare November 4, 2024 08:05
@jieyouxu jieyouxu added C-CI Category: CI for this repo A-linkcheck Area: linkcheck labels Nov 4, 2024
@jieyouxu jieyouxu added A-CI Area: CI C-CI Category: CI for this repo WG-rustc-dev-guide Working group: rustc-dev-guide and removed C-CI Category: CI for this repo A-CI Area: CI labels Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-linkcheck Area: linkcheck C-CI Category: CI for this repo S-waiting-on-review Status: this PR is waiting for a reviewer to verify its content WG-rustc-dev-guide Working group: rustc-dev-guide
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants