Document behavior of multiple stability attributes on items #2128
+11
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jieyouxu
added
T-libs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This documents the changes made in rust-lang/rust#131824, and so should be blocked on that.
The checklist for stabilizing a library feature (and its mirror in the standard library developers guide) technically still works; its suggestion to change
#[unstable]attributes to#[stable]should always have the correct behavior. Let me know if it should be recommended to avoid mixing#[stable]/#[unstable]or having multiple#[stable]s in hand-written code though; I can make a note about removing rather than changing#[unstable]attributes in that case. cc @rust-lang/libs @rust-lang/libs-api