Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Conventions chapters, add chapter on dependencies #273

Merged
merged 2 commits into from
Mar 13, 2019

Conversation

mark-i-m
Copy link
Member

close #12

@nikomatsakis nikomatsakis self-assigned this Jan 30, 2019
@mark-i-m mark-i-m added the S-waiting-on-review Status: this PR is waiting for a reviewer to verify its content label Mar 7, 2019
Copy link
Contributor

@nikomatsakis nikomatsakis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good.

- The dependency may have transitive dependencies that have one of the above
problems.

TODO: what is the vetting process?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good question for the meta WG to address, I guess. It seems like a quick FCP might make sense.

@nikomatsakis nikomatsakis merged commit aa9bb67 into rust-lang:master Mar 13, 2019
@mark-i-m mark-i-m deleted the conventions branch June 15, 2019 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: this PR is waiting for a reviewer to verify its content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Conventions used in the compiler"
2 participants