Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed the file and title of the diagnostics chapter. #323

Merged
merged 1 commit into from
May 17, 2019

Conversation

Julian-Wollersberger
Copy link
Contributor

When I recently searched for infos in this guide on how to create a warning, I couldn't find any. Later I found it through #14.

The reason was that I didn't know the term 'diagnostics' and that it is the collective term for errors, warnings and lints.

Renaming the chapter to include the word 'error' should help. I think also including 'warning' in the title shouldn't be neccessary, because it's close enough.

When I recently searched for infos in this guide on how to create
a warning, I couldn't find any. Later I found it through rust-lang#14.

The reason was that I didn't know the term 'diagnostics' and that
it is the collective term for errors, warnings and lints.

Renaming the chapter to include the word 'error' should help.
I think also including 'warning' in the title shouldn't be
neccessary, because it's close enought.
Copy link
Member

@mark-i-m mark-i-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@mark-i-m mark-i-m merged commit 14b243d into rust-lang:master May 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants