Skip to content

Clean up and reorganize traits chapter #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 24, 2018
Merged

Clean up and reorganize traits chapter #52

merged 4 commits into from
Feb 24, 2018

Conversation

mark-i-m
Copy link
Member

@nikomatsakis There are a bunch of TODOs scattered throughout that denote things about which I am not sure. I would appreciate some nudges of guidance on those points (and anything else you see) 😄

cc #6

@mark-i-m mark-i-m self-assigned this Feb 12, 2018
@nikomatsakis nikomatsakis mentioned this pull request Feb 12, 2018
Closed
20 tasks
@mark-i-m
Copy link
Member Author

mark-i-m commented Feb 12, 2018 •
edited
Loading

Oh I should note that all I am really doing is reorganizing the traits README. I didn't write most of this myself.

@mark-i-m mark-i-m changed the title [WIP] Clean up and reorganize traits chapter Clean up and reorganize traits chapter Feb 12, 2018
@mark-i-m
Copy link
Member Author

This might need some iteration to fix all the TODOs, but overall, I think it looks reasonable.

@mark-i-m mark-i-m removed their assignment Feb 13, 2018
@mark-i-m mark-i-m added S-waiting-on-review Status: this PR is waiting for a reviewer to verify its content S-blocked Status: this PR is blocked waiting for something labels Feb 15, 2018
@mark-i-m
Copy link
Member Author

Blocked on #45 because I linked to ./param_env.html

@mark-i-m mark-i-m removed the S-blocked Status: this PR is blocked waiting for something label Feb 23, 2018
nikomatsakis
nikomatsakis reviewed Feb 24, 2018
View reviewed changes
Copy link
Contributor

@nikomatsakis nikomatsakis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all seems good. I am thinking about rewriting a new chapter where I describe the (WIP) new architecture I have in mind to develop w/ traits team, which can then also serve as a place for us to collaborate on it.

@nikomatsakis nikomatsakis merged commit 588b1eb into rust-lang:master Feb 24, 2018
@mark-i-m
Copy link
Member Author

Did you have any comments on the TODOs?

@mark-i-m mark-i-m deleted the traits branch May 23, 2018 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikomatsakis nikomatsakis nikomatsakis approved these changes

Assignees
No one assigned
Labels
S-waiting-on-review Status: this PR is waiting for a reviewer to verify its content
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mark-i-m @nikomatsakis