Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reorganize the guide #651

Merged
merged 13 commits into from
Apr 6, 2020
Merged

Reorganize the guide #651

merged 13 commits into from
Apr 6, 2020
+139 −60

Conversation

mark-i-m
Copy link
Member

@mark-i-m mark-i-m commented Apr 1, 2020

cc @rust-lang/wg-learning

Feedback appreciated :)

@spastorino
Copy link
Member

@mark-i-m in my opinion this looks much better and makes way more sense :).

spastorino
spastorino previously approved these changes Apr 1, 2020
View reviewed changes
JohnTitor
JohnTitor previously approved these changes Apr 1, 2020
View reviewed changes
Copy link
Member

@JohnTitor JohnTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from me!

chrissimpkins
chrissimpkins previously approved these changes Apr 1, 2020
View reviewed changes
Copy link
Member

@chrissimpkins chrissimpkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great Mark!

@chrissimpkins
Copy link
Member

I really like the new intro paragraphs. +1!

@mark-i-m mark-i-m dismissed stale reviews from chrissimpkins, JohnTitor, and spastorino via 01f35c7 April 1, 2020 15:17
This was referenced Apr 1, 2020
Closed
Closed
JohnTitor
JohnTitor previously approved these changes Apr 2, 2020
View reviewed changes
tshepang
tshepang previously requested changes Apr 2, 2020
View reviewed changes
Centril
Centril reviewed Apr 2, 2020
View reviewed changes
@chrissimpkins chrissimpkins self-requested a review April 3, 2020 04:07
chrissimpkins
chrissimpkins previously approved these changes Apr 3, 2020
View reviewed changes
@mark-i-m mark-i-m dismissed stale reviews from chrissimpkins and JohnTitor via 209fbab April 3, 2020 16:15
@mark-i-m
Copy link
Member Author

mark-i-m commented Apr 3, 2020

Ok, I have pushed the following changes:

  • Renamed the part titles as discussed above, and updated the intros
  • Move the rustc_interface and rustc_driver parts to the beginning of Part 3 -- feedback appreciated on this
  • Renamed "High-level overview of the compiler source" to "The compiler source code"

@mark-i-m
Copy link
Member Author

mark-i-m commented Apr 3, 2020

CI is finally green 💚

tshepang
tshepang reviewed Apr 4, 2020
View reviewed changes
tshepang
tshepang reviewed Apr 4, 2020
View reviewed changes
@mark-i-m
Copy link
Member Author

mark-i-m commented Apr 4, 2020

Thanks all! I think this is ready for a final review?

chrissimpkins
chrissimpkins previously approved these changes Apr 5, 2020
View reviewed changes
Copy link
Member

@chrissimpkins chrissimpkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mark-i-m
Copy link
Member Author

mark-i-m commented Apr 5, 2020

CI is green again

@spastorino spastorino requested a review from tshepang April 6, 2020 16:20
@spastorino spastorino dismissed tshepang’s stale review April 6, 2020 16:23

Already resolved.

@spastorino spastorino merged commit 269b5f0 into rust-lang:master Apr 6, 2020
@mark-i-m mark-i-m deleted the reorg-2 branch April 6, 2020 16:40
@chrissimpkins chrissimpkins mentioned this pull request Apr 7, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Centril Centril

@spastorino spastorino

@chrissimpkins chrissimpkins

@JohnTitor JohnTitor

@tshepang tshepang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@mark-i-m @spastorino @chrissimpkins @tshepang @Centril @JohnTitor