Skip to content

Extern blocks are allowed for #[track_caller] now. #710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 23, 2020
Merged

Extern blocks are allowed for #[track_caller] now. #710

merged 1 commit into from
May 23, 2020

Conversation

anp
Copy link
Contributor

@anp anp commented May 23, 2020

LeSeulArtichaut
LeSeulArtichaut approved these changes May 23, 2020
View reviewed changes
Copy link
Contributor

@LeSeulArtichaut LeSeulArtichaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@LeSeulArtichaut
Copy link
Contributor

CI failure is due to a broken link unrelated to this PR which should be fixed by #711. Once it lands you might have to rebase on master.

@mark-i-m
Copy link
Contributor

#711 is merged :)

@LeSeulArtichaut
Copy link
Contributor

I think I can just re-run the tests? Since this PR doesn't conflict this should be fine I guess.

@LeSeulArtichaut LeSeulArtichaut merged commit d10f70b into rust-lang:master May 23, 2020
@anp anp deleted the patch-1 branch May 23, 2020 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@LeSeulArtichaut LeSeulArtichaut LeSeulArtichaut approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anp @LeSeulArtichaut @mark-i-m