Add a chapter on all the identifiers used through rustc
#872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeSeulArtichaut
force-pushed
the
rustc-ids
branch
from
80f9608 to
d23b66b
Compare
tshepang
reviewed
Sep 10, 2020
Co-authored-by: Tshepang Lekhonkhobe <tshepang@gmail.com>
jyn514
approved these changes
Sep 11, 2020
|
You might want to update the HIR chapter to point at this one. I think there is some content about identifiers there too. |
LeSeulArtichaut
force-pushed
the
rustc-ids
branch
from
b881dd0 to
d777b6d
Compare
LeSeulArtichaut
force-pushed
the
rustc-ids
branch
from
d777b6d to
c56ac82
Compare
LeSeulArtichaut
added
the
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@rust-lang/wg-rustc-dev-guide I don't really know what's the best way organizing all of this. I'm not satisfied with the HIR IDs being described in detail in both the HIR chapter and this new one, and at the same time I'm not sure we should remove them from the HIR chapter because they are needed to understand the rest of the chapter.
Replaces #759, closes #748.