Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document new way to not build LLVM #878

Merged
merged 1 commit into from
Oct 4, 2020

Conversation

matklad
Copy link
Member

@matklad matklad commented Sep 13, 2020

```

Downloading LLVM from CI is still experimental though, and might not be
available on all platforms. Otherwise, we'd make it a default!
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not feel like the right place to indicate planned policy/default, here referring to "we'd make it a default".

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also was done in the interest of future compatibility. The thing is in flux, so I find it useful:

  • to document it early, even if incomplete
  • to be clear that there might be changes, and that the docs might be out of date
  • to not be super strict with keeping the docs up to date.

Copy link
Member

@tshepang tshepang Sep 13, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was only referring to "Otherwise, we'd make it a default". First sentence is all good.

@LeSeulArtichaut
Copy link
Contributor

Since the previous discussion stalled out, I'd be in favour of landing this to get it in the guide now, and eventually rework the wording in a follow-up PR

Copy link
Member

@mark-i-m mark-i-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @LeSeulArtichaut. I think we should go ahead and merge this and iterate later if it causes confusion.

@jyn514
Copy link
Member

jyn514 commented Oct 4, 2020

Sounds good to me.

@jyn514 jyn514 merged commit 95650a8 into rust-lang:master Oct 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants