Skip to content

Document the SessionDiagnostic derive macro. #961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 3, 2020
Merged

Document the SessionDiagnostic derive macro. #961

merged 3 commits into from
Dec 3, 2020

Conversation

jumbatm
Copy link
Contributor

@jumbatm jumbatm commented Nov 15, 2020

Documents the #[derive(SessionDiagnostic) macro implemented in rust-lang/rust#75138.

cc @oli-obk

oli-obk
oli-obk approved these changes Nov 15, 2020
View reviewed changes
Copy link
Contributor

@oli-obk oli-obk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome! Thanks for writing it up. I think with this we can now start creating E-easy issues for various sites in the compiler where we could move to SessionDiagnostic

LeSeulArtichaut
LeSeulArtichaut previously requested changes Nov 15, 2020
View reviewed changes
Copy link
Contributor

@LeSeulArtichaut LeSeulArtichaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some lines are too long and exceed the 100 characters limit required to pass CI. I'd suggest to use [][]-style links instead of the inline []()-style links.

@LeSeulArtichaut
Copy link
Contributor

Also this design looks fantastic! It's awesome that someone finally implemented it ❤️

@LeSeulArtichaut LeSeulArtichaut added the S-waiting-on-author Status: this PR is waiting for additional action by the OP label Nov 15, 2020
camelid
camelid reviewed Nov 15, 2020
View reviewed changes
Copy link
Member

@camelid camelid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feature looks pretty cool!

@jumbatm
Copy link
Contributor Author

jumbatm commented Nov 16, 2020

Thanks for the suggestions, all :)

@rustbot modify labels: waiting-on-review

@rustbot rustbot added the S-waiting-on-review Status: this PR is waiting for a reviewer to verify its content label Nov 16, 2020
mark-i-m
mark-i-m approved these changes Dec 3, 2020
View reviewed changes
Copy link
Member

@mark-i-m mark-i-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mark-i-m mark-i-m merged commit 459e414 into rust-lang:master Dec 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camelid camelid camelid left review comments

@oli-obk oli-obk oli-obk approved these changes

@mark-i-m mark-i-m mark-i-m approved these changes

@LeSeulArtichaut LeSeulArtichaut LeSeulArtichaut left review comments

Assignees
No one assigned
Labels
S-waiting-on-author Status: this PR is waiting for additional action by the OP S-waiting-on-review Status: this PR is waiting for a reviewer to verify its content
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jumbatm @LeSeulArtichaut @oli-obk @mark-i-m @camelid @rustbot