Skip to content

Adds a dev guide section on Rust Coverage #985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 7, 2020
Merged

Adds a dev guide section on Rust Coverage #985

merged 1 commit into from
Dec 7, 2020

Conversation

@richkadel
Copy link
Contributor

@richkadel richkadel commented Dec 6, 2020

No description provided.

@richkadel
Copy link
Contributor Author

richkadel commented Dec 6, 2020

cc: @tmandry @wesleywiser

@richkadel
Copy link
Contributor Author

richkadel commented Dec 6, 2020

Dev guide section for tracking issue rust-lang/rust#79121

@richkadel richkadel force-pushed the llvm-coverage-rustc-dev-guide branch from ffe1186 to bda44c0 Compare December 6, 2020 22:11
jyn514
jyn514 reviewed Dec 6, 2020
View reviewed changes
Copy link
Member

@jyn514 jyn514 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, this is super detailed 😄 I'll let tmandry review the content, I just have some typographical nits.

@richkadel richkadel force-pushed the llvm-coverage-rustc-dev-guide branch 2 times, most recently from 0add8bf to d349635 Compare December 6, 2020 22:23
@richkadel
Copy link
Contributor Author

richkadel commented Dec 6, 2020

typographical nits

@jyn514 - Thanks for finding the typos!

@jyn514 jyn514 added the S-waiting-on-review Status: this PR is waiting for a reviewer to verify its content label Dec 6, 2020
@richkadel richkadel force-pushed the llvm-coverage-rustc-dev-guide branch 2 times, most recently from c38a80b to 84467e0 Compare December 6, 2020 23:10
@richkadel
Copy link
Contributor Author

richkadel commented Dec 6, 2020

@tmandry - went through all of the links and corrected issues. I think the links are all valid now.

wesleywiser
wesleywiser reviewed Dec 7, 2020
View reviewed changes
@wesleywiser
Copy link
Member

wesleywiser commented Dec 7, 2020

It might be good to have a small discussion about the code coverage format version: Newer versions generally have features we might like to use but aren't supported by the min version of LLVM rustc allows. If the version of LLVM is too old, we generate a compiler error when using the code coverage feature.

Overall, this is really great work! 👍

@richkadel richkadel force-pushed the llvm-coverage-rustc-dev-guide branch from 84467e0 to 3169d3b Compare December 7, 2020 18:26
@richkadel
Copy link
Contributor Author

richkadel commented Dec 7, 2020

It might be good to have a small discussion about the code coverage format version: Newer versions generally have features we might like to use but aren't supported by the min version of LLVM rustc allows. If the version of LLVM is too old, we generate a compiler error when using the code coverage feature.

@wesleywiser - Added as a footnote. PTAL.

Thanks!

@richkadel richkadel force-pushed the llvm-coverage-rustc-dev-guide branch from 3169d3b to 30da3ed Compare December 7, 2020 18:31
wesleywiser
wesleywiser approved these changes Dec 7, 2020
View reviewed changes
Copy link
Member

@wesleywiser wesleywiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@jyn514 jyn514 merged commit 9f612da into rust-lang:master Dec 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jyn514 jyn514 jyn514 left review comments

@wesleywiser wesleywiser wesleywiser approved these changes

Assignees

No one assigned

Labels

S-waiting-on-review Status: this PR is waiting for a reviewer to verify its content

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@richkadel @wesleywiser @jyn514