Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update logging section and explain RUSTC_LOG_COLOR #997

Merged
merged 5 commits into from
Dec 31, 2020
Merged

Update logging section and explain RUSTC_LOG_COLOR #997

merged 5 commits into from
Dec 31, 2020

Conversation

camelid
Copy link
Member

@camelid camelid commented Dec 30, 2020

Closes #991.

r? @jyn514

@camelid camelid added the S-waiting-on-review Status: this PR is waiting for a reviewer to verify its content label Dec 30, 2020
LeSeulArtichaut
LeSeulArtichaut reviewed Dec 30, 2020
View reviewed changes
Copy link
Contributor

@LeSeulArtichaut LeSeulArtichaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, left a few nits

jyn514
jyn514 reviewed Dec 30, 2020
View reviewed changes
Copy link
Member

@jyn514 jyn514 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for writing this up!

camelid and others added 3 commits December 30, 2020 15:34
@camelid
Copy link
Member Author

camelid commented Dec 30, 2020

Should be ready for another review!

LeSeulArtichaut
LeSeulArtichaut approved these changes Dec 30, 2020
View reviewed changes
Copy link
Contributor

@LeSeulArtichaut LeSeulArtichaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Yeah, so it looks like you need RUSTC_LOG_COLOR to color logs of parts of rustc that Miri calls. I should probably add a paragraph explaining that.

Do you want to do this in a follow-up?

@camelid
Copy link
Member Author

camelid commented Dec 30, 2020

Yeah, so it looks like you need RUSTC_LOG_COLOR to color logs of parts of rustc that Miri calls. I should probably add a paragraph explaining that.

Do you want to do this in a follow-up?

See 930797d :)

@LeSeulArtichaut
Copy link
Contributor

Oh, great, the comment was not marked as resolved, I thought you didn't resolve it. Merging then

@LeSeulArtichaut LeSeulArtichaut merged commit f2e7d46 into rust-lang:master Dec 31, 2020
@camelid camelid deleted the log-color branch December 31, 2020 00:11
@camelid camelid mentioned this pull request Jan 4, 2021
Closed
@camelid camelid linked an issue Jan 4, 2021 that may be closed by this pull request
Update logging for tracing #892
Closed
camelid added a commit to camelid/rustc-dev-guide that referenced this pull request Jan 5, 2021
@camelid
Remove old sentence that should have been removed
71a69b3 
It was mistakenly not removed in rust-lang#997.
@camelid camelid mentioned this pull request Jan 5, 2021
Merged
camelid added a commit to camelid/rustc-dev-guide that referenced this pull request Jan 5, 2021
@camelid
Remove old sentence that should have been removed
2b4962f 
It was mistakenly not removed in rust-lang#997.
jyn514 pushed a commit that referenced this pull request Jan 5, 2021
@camelid
Remove old sentence that should have been removed
92e47a0 
It was mistakenly not removed in #997.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jyn514 jyn514 jyn514 left review comments

@LeSeulArtichaut LeSeulArtichaut LeSeulArtichaut approved these changes

Assignees
No one assigned
Labels
S-waiting-on-review Status: this PR is waiting for a reviewer to verify its content
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document how to set the color for logging output Update logging for tracing
3 participants
@camelid @LeSeulArtichaut @jyn514