Improve wording, fix typos, add edition to Cargo.toml
#20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Noratrieb
reviewed
Jan 13, 2024
There was a problem hiding this comment.
Thank you for the PR and sorry for the, uh, very long review time^^. Two small changes, then we can merge it.
also cc @wesleywiser / @davidtwco since this touches something related to licensing, but it looks fine to me
README.md
Outdated
Comment on lines
11
to
12
| Within `rustc`, it consistently outperforms FNV-based algorithms. | ||
| The collision rate is similar or slightly worse than FNV. |
There was a problem hiding this comment.
Suggested change
| Within `rustc`, it consistently outperforms FNV-based algorithms. | |
| The collision rate is similar or slightly worse than FNV. | |
| Within `rustc`, it consistently outperforms every other tested algorithm (for example, FNV). | |
| The collision rate is similar or slightly worse than others. |
There have been a lot of benchmarks and fxhash has always come out on the winning side.
There was a problem hiding this comment.
Changed. "(such as FNV)" sounds more suitable to me.
|
Note that this PR has conflicts with master and requires a rebase. |
davidtwco
approved these changes
Jan 15, 2024
This change is to be consistent with rust-lang/rust. Their change was made in October 2019. The PR over there: [Replace code of conduct with link #65141](rust-lang/rust#65141)
Edition added as 2018. 2015 throws errors. Version is not changed.
This change is to be consistent with rust-lang/rust. Their change was made in January 2020. The PR over there: [Remove appendix from LICENCE-APACHE](rust-lang/rust#67734)
Language is updated to be consistent with rust-lang/rust, particularly the std::collections::HashMap page. Changes: - newline in the example after `use` statement for clarity - fix typo in type definition for `FxHashSet` (previously said it was for a hashmap) - wording and phrasing - consistent language between `README.md` and the docs
Incorporates Nilstrieb's suggestion in the review for PR rust-lang#20
Removes the license header in *lib.rs* to match up with the main repo.
|
I rebased to the latest master and incorporated both suggestions. Ready for review or merging :) |
I missed this when fixing conflicts. This matches the `FxHashMap` description.
Noratrieb
reviewed
Mar 1, 2024
Co-authored-by: Nilstrieb <48135649+Nilstrieb@users.noreply.github.com>
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All doc changes, except for adding version to
Cargo.tomland updating the crate description.Language is changed to be consistent with rust-lang/rust.
See commit messages for more details.