Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"full builds of benchmark" message should include profile #1048

Closed
jyn514 opened this issue Oct 3, 2021 · 1 comment · Fixed by #1146
Closed

"full builds of benchmark" message should include profile #1048

jyn514 opened this issue Oct 3, 2021 · 1 comment · Fixed by #1146
Labels
A-try-runs Issues related to performing try runs C-improvement This isn't a feature or a bug fix but makes things better

Comments

@jyn514
Copy link
Member

jyn514 commented Oct 3, 2021

rust-lang/rust#88679 (comment) says "Very large regression in instruction counts (up to 6.6% on full builds of regression-31157)". But the actual regressed build is "regression-31157-doc".
@Mark-Simulacrum Mark-Simulacrum changed the title "full builds of benchmark" message should include filter "full builds of benchmark" message should include profile Oct 3, 2021
@rylev rylev added A-try-runs Issues related to performing try runs C-improvement This isn't a feature or a bug fix but makes things better labels Oct 6, 2021
@jyn514
Copy link
Member Author

jyn514 commented Nov 24, 2021

This came up again in today's compiler triage meeting: https://rust-lang.zulipchat.com/#narrow/stream/238009-t-compiler.2Fmeetings/topic/.5Bweekly.5D.202021-11-24.20.2354818/near/262609391

@lqd lqd mentioned this issue Jan 13, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-try-runs Issues related to performing try runs C-improvement This isn't a feature or a bug fix but makes things better
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Include the profile in a result's summary; more documentation for rust-timer commands lqd/rustc-perf
2 participants
@rylev @jyn514