Include the profile in a result's summary; more documentation for rust-timer commands #1146
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1048 by changing the summary line of a benchmark result by adding its profile as well.
This matches the compare page's "Benchmark & Profile" column, so I think it's clearer in that sense (but maybe it can be put elsewhere in the summary sentence). But this change will also impact the automated weekly report: I therefore wonder if this is how you'd want it to be fixed ?
For example, this summary would now mention that the regression was in a
doc
benchmark: from "Very large regression in instruction counts (up to 6.6% onfull
builds ofregression-31157
)" to "Very large regression in instruction counts (up to 6.6% onfull
builds ofregression-31157 doc
)".And this one would go from "Large regression in instruction counts (up to 1.6% on
incr-unchanged
builds ofderive
)" to "Large regression in instruction counts (up to 1.6% onincr-unchanged
builds ofderive check
)"Resolves #1099 by adding a tiny bit more documentation about rust-timer commands on the Help page, and the link Scott suggests.
Here's how it looks rendered