Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH perf bot message: number of perf builds in rollup reported by perf bot != PR's in rollup #1390

Closed
klensy opened this issue Aug 10, 2022 · 3 comments · Fixed by #1394
Closed

Comments

@klensy
Copy link
Contributor

klensy commented Aug 10, 2022

rust-lang/rust#100356 contains 8 PRs in rollup, but perf bot message talks about only one PR rust-lang/rust#100356 (comment)

probably #1372 so @rylev ?

@klensy klensy changed the title GH perf bot message: number of perf builds in rollup != PR's in rollup GH perf bot message: number of perf builds in rollup reported by perf bot != PR's in rollup Aug 10, 2022
@Mark-Simulacrum
Copy link
Member

Looks like some commits were added to the branch after merging perhaps? rust-lang/rust#100356 (commits)

(Cc @ehuss though I suspect GitHub may be lying about who pushed them)

I wouldn't have expected us to get the commits wrong regardless, but seems like a plausible explanation.

@ehuss
Copy link

ehuss commented Aug 10, 2022

Oh, sorry, I think I know what happened. I had rebooted my machine between two different OS's and that screws up my clock, and I forgot to resync it. The timestamp on the commit is in the future, and GitHub seems to have placed the in-the-future time in the timeline that way.

@Mark-Simulacrum
Copy link
Member

Hm, ok. I don't think that should've caused any glitches in perf then, so probably something else went wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants