Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install measureme tooling in collect script #1063

Merged
merged 1 commit into from
Oct 7, 2021

Conversation

rylev
Copy link
Member

@rylev rylev commented Oct 7, 2021

This should remove one more manual aspect of running perf.rlo.

@rylev rylev marked this pull request as ready for review October 7, 2021 11:49
@Mark-Simulacrum Mark-Simulacrum merged commit ac6c94c into rust-lang:master Oct 7, 2021
@michaelwoerister
Copy link
Member

Should this have the --force flag so we always get the newest version? Or will it already re-install if the version is different?

@Mark-Simulacrum
Copy link
Member

Cargo auto-upgrades these days, I believe, while --force would ignore the existing version and reinstall regardless (which just wastes time).

@rylev rylev deleted the update-measureme-tooling branch October 8, 2021 14:53
@rylev
Copy link
Member Author

rylev commented Oct 8, 2021

Cargo auto-upgrades these days, I believe, while --force would ignore the existing version and reinstall regardless (which just wastes time).

This is correct. I've already tested that it upgrades if the version found is not the same (which in the case of git deps is determined by git commit sha I believe).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants