Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly calculate largest change independent of its direction in PR summary table #1272

Merged
merged 1 commit into from
Apr 4, 2022
Merged

Correctly calculate largest change independent of its direction in PR summary table #1272

merged 1 commit into from
Apr 4, 2022

Conversation

Kobzol
Copy link
Contributor

@Kobzol Kobzol commented Apr 4, 2022

The previous logic was wrong, as could be seen e.g. here.

@Kobzol Kobzol requested a review from rylev April 4, 2022 10:36
rylev
rylev approved these changes Apr 4, 2022
View reviewed changes
Copy link
Member

@rylev rylev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops! Sorry for not catching this before! 👍

@Kobzol Kobzol merged commit 9636d7a into master Apr 4, 2022
@Kobzol Kobzol deleted the summary-max-row branch April 4, 2022 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rylev rylev rylev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kobzol @rylev