Teach rustc-fake to tell the truth about subprocess exit statuses #1366
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves the ci failure observed in rust-lang/rust#99431
turns out the impl of
fn exec()
in rustc-perf'srustc-fake
is incorrect on windows and only reports a failure when the subprocess fails to spawn, but if it spawns correctly it always reports success rather than checking the exit status of the subprocess. This causes the probe in anyhow to succeed and enable#[cfg(backtrace)]
which then causes anyhow to fail to compile, but because it was inside ofrustc-fake
it reports success and continues! This happens quite a bit and we get some very exciting compiler errors whenRUST_LOG=collector=trace
is set.