Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On Demand self profile data #1367

Merged
merged 3 commits into from
Jul 26, 2022

Conversation

rylev
Copy link
Member

@rylev rylev commented Jul 26, 2022

This moves fetching of self profile data from the database to s3. The self query data is still written to the database so that if we want/need to revert this, no data is lost.

This requires changes to the analyzeme crate (here rust-lang/measureme#200) which we may want to merge first before merging this.

@rylev rylev requested a review from Mark-Simulacrum July 26, 2022 10:03
@Mark-Simulacrum
Copy link
Member

This requires changes to the analyzeme crate (here rust-lang/measureme#200) which we may want to merge first before merging this.

I don't think it's critical so long as we don't delete the upstream branch before we bump back to stable here; we don't carry the same need to keep commits building as in rust-lang/rust. But it would probably be nice for that to merge first.

@rylev
Copy link
Member Author

rylev commented Jul 26, 2022

@Mark-Simulacrum I tried this locally, and it seems to work. The local request runs slower than on production, but we're doing less work so I imagine that's just the difference between my laptop and the server running prod. Do we want to merge this now or wait for the analyzeme PR to merge?

@Mark-Simulacrum
Copy link
Member

Let's go ahead and merge, so we can evaluate whether there's problems in production (not that we have metrics...). I don't think the branch is a huge hazard.

@Mark-Simulacrum Mark-Simulacrum merged commit 4998f79 into rust-lang:master Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants