Clean up code conversions of Profile enum #1511
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cleans up a bit some conversion of the
Profile
type and allow to have it in one place.Another thing I wondered: this type is also present in both
collector/src/benchmark/profile.rs
anddatabase/src/lib.rs
. Is there a reason why it is duplicated like this?collector/src/benchmark/
hasdatabase
as a dependency, so is there a particular reason whyProfile
was also created incollector/src/benchmark
? If not I'm planning to merge both types in a follow-up PR.