Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin the rustc version used to compile collector #2046

Merged
merged 1 commit into from
Feb 25, 2025

Conversation

Kobzol
Copy link
Contributor

@Kobzol Kobzol commented Feb 25, 2025

Just to avoid potential surprises with the collector being recompiled with a different (unstable) rustc every day.

Just to avoid potential surprises with the collector being recompiled with a different (unstable) rustc every day.
Copy link
Member

@Mark-Simulacrum Mark-Simulacrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems ok, though I wonder if we should be trying to wire this up to dependabot or something....

@Kobzol
Copy link
Contributor Author

Kobzol commented Feb 25, 2025

If we bump MSRV in the repo, but forget to change it in the collect.sh script, we will find about that soon enough, I suppose 😆 But usually I bump it by grepping the old version, so we should see all its occurrences.

@Kobzol Kobzol merged commit 168f832 into rust-lang:master Feb 25, 2025
11 checks passed
@Kobzol Kobzol deleted the collector-pin-version branch February 25, 2025 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants