Skip to content

Check if collector is active when starting it #2239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 4, 2025
Merged

Check if collector is active when starting it #2239

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion collector/src/bin/collector.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1389,7 +1389,9 @@ Make sure to modify `{dir}/perf-config.json` if the category/artifact don't matc
let collector_config = rt
.block_on(conn.start_collector(&collector_name, &git_sha))?
.ok_or_else(|| {
anyhow::anyhow!("Collector with name `{collector_name}` not found")
anyhow::anyhow!(
"No active collector with the name `{collector_name}` not found"
)
})?;

if collector_config.target().as_str() != host_target_tuple {
Expand Down
3 changes: 2 additions & 1 deletion database/src/pool/postgres.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1816,7 +1816,8 @@ where
last_heartbeat_at = NOW(),
commit_sha = $2
WHERE
name = $1
name = $1 AND
is_active = true
RETURNING
target,
benchmark_set,
Expand Down
Loading