Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add keccak crate #265

Merged
merged 1 commit into from
Jul 30, 2018
Merged

Add keccak crate #265

merged 1 commit into from
Jul 30, 2018

Conversation

RalfJung
Copy link
Member

Quoting @oli-obk:

The keccak crate is a great benchmark for ridiculous numbers of locals and basic blocks. We should add it to the list of perf tests.

So, let's do that. :) This adds an old version, one that still actually has "ridiculous numbers of locals and basic blocks". Later versions reduced that, also to help with compile-times -- but the old version is a good stress-test, so I think it is the better benchmark.
Concretely, this is an exact copy of https://github.com/RustCrypto/sponges/tree/a417e97a41776a2feee20f98e1d97917b7ad35f0/keccak.

Is there anything else needed, other than adding it in this directory?

@RalfJung
Copy link
Member Author

RalfJung commented Jul 30, 2018

I wanted to also add a benchmark @oli-obk and me developed, but as rust-lang/rust#52849 (comment) shows it is currently really slow. So I guess I better wait?

@RalfJung RalfJung changed the title Add keccak create Add keccak crate Jul 30, 2018
Quoting @oli-obk:
> The keccak crate is a great benchmark for ridiculous numbers of locals and basic blocks. We should add it to the list of perf tests.
@Mark-Simulacrum
Copy link
Member

Pending CI passing this looks good.

I think I'd be fine to add the other benchmark if it's actually 30 seconds -- many of our benchmarks are ~5-10 minutes long so a 30 second or minute long build won't do all that much :)

@RalfJung
Copy link
Member Author

It's 30 seconds after reducing complexity.^^ The original one (which takes <1min on a nightly from a week ago) did not complete compilation in 7min, then I stopped it...

@Mark-Simulacrum
Copy link
Member

Ah, okay, then yeah, let's hold off on that. Looks like CI here has passed so merging and deploying shortly.

@Mark-Simulacrum Mark-Simulacrum merged commit c4679f0 into rust-lang:master Jul 30, 2018
@RalfJung
Copy link
Member Author

RalfJung commented Jul 30, 2018

Great, thanks!

FWIW, keccak regressed 2% since 2018-07-07. Doesn't seem big enough to track separately, I guess. Also maybe fixing rust-lang/rust#52849 will fix that as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants