-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add testing of collector profile_local
.
#702
Conversation
I've abused the |
Hm, I think |
|
The tests are failing due to an ICE when compiling
|
be46d5e
to
271c763
Compare
The ICE is occurring also for the trivial change in #703. Might be a regression in the latest nightly rustc? |
I think this is rust-lang/rust#74614 |
#704 should have fixed CI, I'm closing/reopening this to re-trigger it here. |
9cec8b3
to
13cef91
Compare
Added some commits that are definitely necessary, but not sure what file it's not finding. |
I think I'll just remove the self-profiling testing, I forgot about needing all the |
b3dd51a
to
6786461
Compare
I rebased to get #704 but somehow I'm still getting the ICE in the tests. /me scratches head |
This happened to me multiple times somehow as well, generally I've felt like a number of times my pushes to this PR have just been entirely ignored (i.e., CI runs but on an old commit somehow). My only theory is that GitHub is having problems again..
It looks like the newly added CI job needs to swap out nightly for beta. |
6786461
to
d760251
Compare
That would be it! |
Progress: the
The exact invocation is I might just drop the |
Also neaten up `ci/check-benchmarks.sh` by using `set -e`.
d760251
to
028747a
Compare
Presumably whatever VM GitHub Actions puts us in is insufficiently "native" for instruction counting, I guess? Odd that cycles (allegedly) works though. |
This finishes up #681. |
Because testing is good.