Use runtime env in build script #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While build.rs runtime and compile-time environment coincide when using cargo, they may not when using other build systems (notably bazel, which is therefore unable to build a project depending on this crate). As explained in [the docs][], build scripts should get their inputs from the environment at runtime, not during compilation. [the docs]:https://doc.rust-lang.org/cargo/reference/build-scripts.html#inputs-to-the-build-script
|
👋 @wesleywiser would you mind reviewing this? For codeql we use Bazel for building, and without this the bazel rust bindings are unable to build if this crate happens to be in the dependencies. This might change in the future (i.e. |
tgross35
approved these changes
Apr 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While
build.rsruntime and compile-time environment coincide when using cargo, they may not when using other build systems (notably bazel, which is therefore unable to build a project depending on this crate).As explained in the docs, build scripts should get their inputs from the environment at runtime, not during compilation.
Closes #22