Skip to content

Source attribution #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bjorn3 opened this issue Oct 3, 2020 · 5 comments · Fixed by #2
Closed

Source attribution #1

bjorn3 opened this issue Oct 3, 2020 · 5 comments · Fixed by #2

Comments

@bjorn3
Copy link
Member

bjorn3 commented Oct 3, 2020

Hi @antoyo! I just saw this project. I am always exited about the development of alternative codegen backends for rustc. I noticed that you have copied substantial parts of my rustc backend called rustc_codegen_cranelift. While I don't have any problems with this, (I licensed it using a permissive dual-license after all) I would greatly appreciate it if you attribute the copied parts to me (and any relevant contributors to rustc_codegen_cranelift).

@antoyo
Copy link
Contributor

antoyo commented Oct 3, 2020

Sure. I'm not sure exactly how to do that. Can you provide me some pointers? (And sorry for forgetting to do it.)

@bjorn3
Copy link
Member Author

bjorn3 commented Oct 3, 2020

Not a lawyer, but this is what I could find:

The MIT license says:

The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software.

The Apache-2.0 license talks about a NOTICE file:

If the Work includes a "NOTICE" text file as part of its distribution, then any Derivative Works that You distribute must include a readable copy of the attribution notices contained within such NOTICE file, excluding those notices that do not pertain to any part of the Derivative Works, in at least one of the following places: within a NOTICE text file distributed as part of the Derivative Works; within the Source form or documentation, if provided along with the Derivative Works; or, within a display generated by the Derivative Works, if and wherever such third-party notices normally appear. The contents of the NOTICE file are for informational purposes only and do not modify the License. You may add Your own attribution notices within Derivative Works that You distribute, alongside or as an addendum to the NOTICE text from the Work, provided that such additional attribution notices cannot be construed as modifying the License.

An example I could find is https://github.com/apache/httpd/blob/trunk/NOTICE

You could make a NOTICE file and tell which files/directories were copied from rustc_codegen_cranelift, that I am the author, the license and maybe also the exact commit you copied it from. In addition both MIT and Apache-2.0 require you to distribute the license with any works that are (substantial) derivatives. Because I licensed it as MIT OR Apache-2.0 at your option, you can choose to include either license file, or you could include both.

@antoyo antoyo mentioned this issue Oct 3, 2020
@antoyo
Copy link
Contributor

antoyo commented Oct 3, 2020

@bjorn3 I opened pull request #2. I couldn't find what your name is so I put your username.
Could you please check that it looks alright?
I'm hoping I didn't forget a file in that list.
Thanks.

@bjorn3
Copy link
Member Author

bjorn3 commented Oct 3, 2020

My username is fine. I didn't thoroughly check of you missed a file, but from a quick look at the list it didn't seem like you missed one.

@antoyo antoyo closed this as completed in #2 Oct 3, 2020
@antoyo
Copy link
Contributor

antoyo commented Oct 3, 2020

Thanks for the quick review.

And again, sorry for not including that right away.

antoyo added a commit that referenced this issue Mar 30, 2024
remove debug info from emitting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants