-
Notifications
You must be signed in to change notification settings - Fork 77
Source attribution #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Sure. I'm not sure exactly how to do that. Can you provide me some pointers? (And sorry for forgetting to do it.) |
Not a lawyer, but this is what I could find: The MIT license says:
The Apache-2.0 license talks about a NOTICE file:
An example I could find is https://github.com/apache/httpd/blob/trunk/NOTICE You could make a NOTICE file and tell which files/directories were copied from rustc_codegen_cranelift, that I am the author, the license and maybe also the exact commit you copied it from. In addition both MIT and Apache-2.0 require you to distribute the license with any works that are (substantial) derivatives. Because I licensed it as MIT OR Apache-2.0 at your option, you can choose to include either license file, or you could include both. |
My username is fine. I didn't thoroughly check of you missed a file, but from a quick look at the list it didn't seem like you missed one. |
Thanks for the quick review. And again, sorry for not including that right away. |
Hi @antoyo! I just saw this project. I am always exited about the development of alternative codegen backends for rustc. I noticed that you have copied substantial parts of my rustc backend called rustc_codegen_cranelift. While I don't have any problems with this, (I licensed it using a permissive dual-license after all) I would greatly appreciate it if you attribute the copied parts to me (and any relevant contributors to rustc_codegen_cranelift).
The text was updated successfully, but these errors were encountered: