Change example to automatically determine filename

[philipc]

This is something I hacked together to allow me to automatically apply some clippy fixes. Not sure if this is something that is desired, but I thought I'd share in case others find it useful (eg see #130). Note that this overwrites the existing files. Also I know nothing about the json format for the suggestions, I'm probably making assumptions that I shouldn't.

My usage is:

cargo clippy --message-format json | jq .message | grep -v ^null > clippy.json
fix-json clippy.json

[killercup]

Lookin' good! Aside from the inline suggestion (maybe combine the two as a match with 3 arms), can you replace the file reading with something like this to support reading from stdin?

    let suggestions = if suggestions_file == "--" {
        use std::io::{stdin, prelude::*, BufReader};
        let mut buffer = String::new();
        BufReader::new(stdin()).read_to_string(&mut buffer)?;
        buffer
    } else {
        fs::read_to_string(&suggestions_file)?
    };

This makes cargo clippy --message-format json | jq .message | grep -v '^null' | fix-json -- work for me!

[philipc]

Done. Also added another commit to skip suggestions that can't be applied. This is all user-beware stuff.

[philipc]

BTW, is there any effort in progress to do this properly? Does that need any help?

[killercup]

Thanks!

BTW, is there any effort in progress to do this properly? Does that need any help?

There is some effort, and we'll have a rustfix working group meeting sometime next week. I'll ping you about it!