This repository has been archived by the owner on Nov 24, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix here just skips any CRs within the original content. Unfortunately this means we can't use direct string slicing when constructing the final text. Instead the text is resolved with
take_while
call that takes new characters until enough content (as defined by span.end - span.start) has been gathered.An alternative approach would be to implement the following:
CodeFix::new
would...LF
-only linebreaks.CodeFix::finish
would restore the original linebreaks (if necessary) once the suggestions have been applied.This alternative approach would have a larger impact by making changes in files that use mixed line endings. Although given this change is in the context of
rustfix
, I would personally argue that such change wouldn't necessarily be bad.