-
Notifications
You must be signed in to change notification settings - Fork 62
Conversation
This is fine.
Forgot to copy this piece of clever algorithm from the CLI.
@@ -143,7 +143,7 @@ fn test_rustfix_with_file<P: AsRef<Path>>(file: P) -> Result<(), Box<Error>> { | |||
|
|||
let mut fixed = code.clone(); | |||
|
|||
for sug in suggestions { | |||
for sug in suggestions.into_iter().rev() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
needs a test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only possible with an additional test that has a replacement that condenses n lines into m<n lines followed by ≥1 replacements.
…which I just added
bors r+ |
51: Fix test edge cases r=oli-obk a=killercup Noticed this while adding test case for ~~fun~~ rust-lang/rust-clippy#2350
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bors r+
51: Fix test edge cases r=oli-obk a=killercup Noticed this while adding test case for ~~fun~~ rust-lang/rust-clippy#2350
Build succeeded |
now we know that a missing review will even fail bors. Although the silent failure is suboptimal |
Hah, thanks for testing ;) What was the issue? That it couldn't merge the PR because Github rejected its request? Do you want me to change the settings to only require bors but not a github review? Edit
I see this in bors' dashboard FYI. Maybe bors is just too polite to leave such a ragequit comment on the PR? {{:badmatch, {:error, :push}},
[{BorsNG.GitHub, :push!, 3,
[file: 'lib/github.ex', line: 47]},
{BorsNG.Worker.Batcher, :complete_batch, 3,
[file: 'lib/batcher.ex', line: 375]},
{BorsNG.Worker.Batcher, :maybe_complete_batch, 1,
[file: 'lib/batcher.ex', line: 362]},
{BorsNG.Worker.Batcher, :handle_cast, 2,
[file: 'lib/batcher.ex', line: 71]},
{:gen_server, :try_dispatch, 4,
[file: 'gen_server.erl', line: 616]},
{:gen_server, :handle_msg, 6,
[file: 'gen_server.erl', line: 686]},
{:proc_lib, :init_p_do_apply, 3,
[file: 'proc_lib.erl', line: 247]}]} |
nah, I'm a quick learner |
Me: the fool who set this up
You: a quick learner
Me in a month: absolutely clueless why bors doesn't work
… Am 18.01.2018 um 12:51 schrieb Oliver Schneider ***@***.***>:
Do you want me to change the settings to only require bors but not a github review?
nah, I'm a quick learner
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Noticed this while adding test case for
funrust-lang/rust-clippy#2350