This repository has been archived by the owner on Nov 24, 2023. It is now read-only.
Warn users when fixes break code #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The rustfix tool detects it, so let's inform the user what just happened! Closes rust-lang#88
This omits the reference to gist (which may confuse people not familiar with gist.github.com), and moves the link to our issue tracker to its own line, which makes copying easier (for those whose terminals don't have a "ctrl+click to open link" feature).
killercup
reviewed
May 6, 2018
cargo-fix/src/cli.rs
Outdated
| "This likely indicates a bug in either rustc or rustfix itself,\n\ | ||
| and we would appreciate a bug report! You're likely to see \n\ | ||
| a number of compiler warnings after this message which rustfix\n\ | ||
| attempted to fix but failed. If you could gist the full output\n\ |
There was a problem hiding this comment.
I wouldn't bet on people understanding what "gist the full output" means… Let's go with "If you could open an issue at … quoting the full output…"
|
Nice. I tweaked the wording a bit and have another PR waiting to add error messages for rustfix internal errors. |
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rustfix tool detects it, so let's inform the user what just happened!
Closes #88