Skip to content

Commit

Permalink
Auto merge of #79536 - davidtwco:focal-fossa-ci, r=pietroalbini
Browse files Browse the repository at this point in the history
ci: use 20.04 on x86_64-gnu-nopt builder

Switch the `x86_64-gnu-nopt` builder to use Ubuntu 20.04.

Ubuntu 20.04 has a more recent gdb version than Ubuntu 16.04 (9.1 vs 7.11.1), which is required for rust-lang/rust#77177, as 16.04's gdb 7.11.1 crashes in some cases with Split DWARF. `x86_64-gnu-nopt` is chosen because it runs compare modes, which is how Split DWARF testing is implemented in rust-lang/rust#77177.

I've not confirmed that the issue is resolved with gdb 9.1 (Feb 2020), but system was using gdb 9.2 (May 2020) and that was fine and it seems more likely to me that the bug was resolved between gdb 7.11.1 (May 2016) and gdb 9.1.

Updating a builder to use 20.04 was suggested by `@Mark-Simulacrum` in rust-lang/rust#77117 (comment). I'm not sure if this is the only change that is required - if more are necessary then I'm happy to do that.

r? `@pietroalbini`
cc `@Mark-Simulacrum`
  • Loading branch information
bors committed Dec 10, 2020
2 parents d7560e8 + fb75c32 commit 80cc2ec
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions src/ci/docker/host-x86_64/x86_64-gnu-nopt/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
FROM ubuntu:16.04
FROM ubuntu:20.04

RUN apt-get update && apt-get install -y --no-install-recommends \
# Avoid interactive prompts while installing `tzdata` dependency with `DEBIAN_FRONTEND`.
RUN apt-get update && DEBIAN_FRONTEND=noninteractive apt-get install -y --no-install-recommends \
g++ \
make \
ninja-build \
Expand Down

0 comments on commit 80cc2ec

Please sign in to comment.