Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

normalize_comments is ignored inside rewrite_missing_comment #2655

Closed
topecongiro opened this issue Apr 28, 2018 · 1 comment
Closed

normalize_comments is ignored inside rewrite_missing_comment #2655

topecongiro opened this issue Apr 28, 2018 · 1 comment
Labels
a-comments good first issue Issues up for grabs, also good candidates for new rustfmt contributors only-with-option requires a non-default option value to reproduce

Comments

@topecongiro
Copy link
Contributor

https://github.com/rust-lang-nursery/rustfmt/blob/d19fc450c06cd480ef2b9e1031b55ff10df080a7/src/comment.rs#L506

We should replace false with context.config.normalize_comments.
@topecongiro topecongiro added good first issue Issues up for grabs, also good candidates for new rustfmt contributors a-comments only-with-option requires a non-default option value to reproduce labels Apr 28, 2018
topecongiro added a commit to topecongiro/rustfmt that referenced this issue Apr 28, 2018
@topecongiro
Temporarily fix tests
3432807 
cc rust-lang#2655.
@cedws cedws mentioned this issue Apr 30, 2018
Closed
@cedws
Copy link

cedws commented Apr 30, 2018

Sorry to go for the low hanging fruit here! Hopefully I'll be able to contribute a little more in future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
a-comments good first issue Issues up for grabs, also good candidates for new rustfmt contributors only-with-option requires a non-default option value to reproduce
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@topecongiro @cedws