Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CI failures #3885

Closed
topecongiro opened this issue Oct 25, 2019 · 6 comments · Fixed by #3889
Closed

Fix CI failures #3885

topecongiro opened this issue Oct 25, 2019 · 6 comments · Fixed by #3889
Labels
good first issue Issues up for grabs, also good candidates for new rustfmt contributors

Comments

@topecongiro
Copy link
Contributor

topecongiro commented Oct 25, 2019 •
edited
Loading

https://travis-ci.com/rust-lang/rustfmt cargo install --path . --force is failling due to picking up the latest crossbeam-channel which is apparently broken with the latest nightly.

Possibly related: rust-lang/cargo#7169.
@topecongiro topecongiro added the good first issue Issues up for grabs, also good candidates for new rustfmt contributors label Oct 25, 2019
@calebcartwright
Copy link
Member

crossbeam-rs/crossbeam#435 - looks like they've already fixed crossbeam-channel but have't released the new version yet

@topecongiro topecongiro mentioned this issue Oct 25, 2019
Merged
@topecongiro
Copy link
Contributor Author

Yes, it looks like cargo has changed its behavior when passed install --path and ignores the Cargo.lock file. I added --locked in the script in #3889 to force cargo to use the dependencies specified in the Cargo.lock.

@calebcartwright
Copy link
Member

Looks like a new 0.4.0 version of crossbeam-channel and a 0.7.0 version of crossbeam-utils have been published with the fix. Would it be worth updating the lockfile with these new versions?

@topecongiro
Copy link
Contributor Author

Yes!

@calebcartwright
Copy link
Member

Will open a PR in a bit with those bumps

@calebcartwright
Copy link
Member

Unfortunately it seems that ignore is pinned on crossbeam-channel v0.3.6 which in turn has a ^v0.6.5 dependency on crossbeam-utils, basically preventing updating either.

I'll follow up with an issue over in ignore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Issues up for grabs, also good candidates for new rustfmt contributors
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add --locked topecongiro/rustfmt
2 participants
@calebcartwright @topecongiro