Skip to content

Error retrieving configuration options for older versions on Config site #4429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
calebcartwright opened this issue Sep 20, 2020 · 4 comments
Labels
bug Panic, non-idempotency, invalid code, etc. documentation good first issue Issues up for grabs, also good candidates for new rustfmt contributors hacktoberfest help wanted

Comments

@calebcartwright
Copy link
Member

To reproduce, go to the rustfmt configuration documentation site (https://rust-lang.github.io/rustfmt/) and change the version to v0.8.1 or v0.7, and observe the Failed to get configuration options for this version, please select the version from the dropdown above. message and empty option list.

image

An ideal fix to this would identify and resolve the root cause of whatever is going on with this issue, although given how ancient the versions in question are (pre 1.0 release), it may be sufficient to just filter these out of the available version list.

Also worth noting (and bonus points for fixing 😄) the ``Failed to get configuration options....` error message remains on the page even after changing to a different version and the configuration options being successfully loaded

@calebcartwright calebcartwright added bug Panic, non-idempotency, invalid code, etc. good first issue Issues up for grabs, also good candidates for new rustfmt contributors help wanted documentation labels Sep 20, 2020
@meemaker
Copy link

😥😥

@gorogoroumaru
Copy link

The rustfmt configuration documentation site tries to fetch configuration options from "https://raw.githubusercontent.com/rust-lang/rustfmt/${this.version}/Configurations.md".
In v0.8.1 and v0.7, this page doesn't exist and fetching fails.

jdollar added a commit to jdollar/rustfmt that referenced this issue Oct 3, 2020
Add code to the doc/index.html file to handle the specific cases for version 0.8.1 and 0.7
of rustfmt where they don't have a explicit configuration.md file. Updated to pull the data
that is within the "Configuring Rustfmt" section of the original README
jdollar added a commit to jdollar/rustfmt that referenced this issue Oct 3, 2020
Add code to the doc/index.html file to handle the specific cases for version 0.8.1 and 0.7
of rustfmt where they don't have a explicit configuration.md file. Updated to pull the data
that is within the "Configuring Rustfmt" section of the original README
@jdollar
Copy link
Contributor

jdollar commented Oct 3, 2020

Tossed up a push request to attempt a solution at this. Updated to pull the "Configuring Rustfmt" section of the README in the case of the older versions.

Looks a little something like this:
image

So it includes some information on styling since it seems like all that was under the same section. I can look into removing that as well and just trimming it down to the items specific to configuring rustfmt there OR I would totally be fine just scrapping this and removing those two versions if the result is too underwhelming to everyone.

Hopefully that helps!

@calebcartwright
Copy link
Member Author

Resolved via #4451

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Panic, non-idempotency, invalid code, etc. documentation good first issue Issues up for grabs, also good candidates for new rustfmt contributors hacktoberfest help wanted
Projects
None yet
Development

No branches or pull requests

4 participants