Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pub on macro_rules! not supported #4728

Closed
JulianKnodt opened this issue Feb 28, 2021 · 2 comments
Closed

pub on macro_rules! not supported #4728

JulianKnodt opened this issue Feb 28, 2021 · 2 comments
Assignees
Labels
bug Panic, non-idempotency, invalid code, etc. p-high

Comments

@JulianKnodt
Copy link
Contributor

https://play.rust-lang.org/?version=nightly&mode=debug&edition=2018&gist=71be237d1aed61df9bbdb665bbd5a056`

I expected to be able to format with rustfmt,

but when running rustfmt there is an error despite compilation succeeding.

The implementation PR is 82296, but unsure if there's a RFC for the original idea.

@JulianKnodt JulianKnodt added the bug Panic, non-idempotency, invalid code, etc. label Feb 28, 2021
@calebcartwright
Copy link
Member

Thanks for the report. We consume the rustc internals via the auto publish crates, so we always lag behind rustc changes somewhat. This should be a straightforward update on our side but may take a little while to pull in and apply the upstream updates

@calebcartwright
Copy link
Member

Closing as this no longer seems relevant given the upstream state (though I expect that if the feature and syntax support are brought back the visibility will be maintained now that we consume the rustc internals via rustc-dev)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Panic, non-idempotency, invalid code, etc. p-high
Projects
None yet
Development

No branches or pull requests

2 participants