-
Notifications
You must be signed in to change notification settings - Fork 917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RUSTC_BLESS=1 cargo test
modifies source files instead of targets
#6056
Comments
(cc @oli-obk in case you remember context from implementing it in rust-lang/rust#114054) |
It was necessary to modify the source because the logic was used to dogfood rustfmt iirc. |
Ah, in a self-test/idempotent-test you want to write to the source. But also from what I can see in those cases the |
Ah yea, in that case, we should only write to the target |
I'd also expect this to write to the target file. |
Reproduction:
My expectation is that this should be writing to
target
, but it was originally implemented for./x
support in the main tree, so I'm not sure if that expects it to modify source files instead for some reason.rustfmt/src/test/mod.rs
Line 838 in ead0fc9
The text was updated successfully, but these errors were encountered: