Skip to content

Changes regular comment to doc comment #836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bluss opened this issue Feb 22, 2016 · 2 comments
Closed

Changes regular comment to doc comment #836

bluss opened this issue Feb 22, 2016 · 2 comments
Labels
a-comments bug Panic, non-idempotency, invalid code, etc. duplicate

Comments

@bluss
Copy link
Member

bluss commented Feb 22, 2016

This change is a change in semantics:

-///// ChunksLazy /////
+/// // ChunksLazy /////

If this would have been at the end of the file (no item after), it breaks the build.
@nikomatsakis
Copy link

I encountered a similar problem in librustc_data_structures:

-    ///////////////////////////////////////////////////////////////////////////
-    // Edge construction and queries
+    /// ////////////////////////////////////////////////////////////////////////
+    /// Edge construction and queries

nikomatsakis added a commit to nikomatsakis/rust that referenced this issue Mar 5, 2016
@nikomatsakis
apply rustfmt to librustc_data_structures, correcting rust-lang/rustf…
43dc48c 
…mt#836
nikomatsakis added a commit to nikomatsakis/rust that referenced this issue Mar 5, 2016
@nikomatsakis
adopt new header style to sidestep rust-lang/rustfmt#836
2529b73
@nrc nrc added bug Panic, non-idempotency, invalid code, etc. a-comments labels Mar 9, 2016
@nrc nrc added the duplicate label Apr 6, 2016
@nrc
Copy link
Member

nrc commented Apr 6, 2016

dup of #652

@nrc nrc closed this as completed Apr 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
a-comments bug Panic, non-idempotency, invalid code, etc. duplicate
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nikomatsakis @nrc @bluss