Fix broken build after use_nested_groups lands on nightly #2218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pietroalbini
force-pushed
the
fix-ast-for-use_nested_groups
branch
from
81ce961 to
9d8cfbc
Compare
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rustfmt will be broken after rust-lang/rust#45846 (support for the
use_nested_groupsfeature) lands on nightly. That PR completly changes the AST forusedeclarations, so imports formatting will break.This PR fixes rustfmt to keep the old behavior with the new AST, and adds partial support for the new features introduced in the rustc PR: some of them will work, some will behave unexpectedly and some will just panic with
unimplemented!.