Add failure mode to write_list
#251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| mem_profiler_chan, | ||
| devtools_chan, | ||
| storage_task, | ||
| supports_clipboard); |
|
looks good! Other than the inline comments, there are a couple of FIXMEs on magic |
| _ if tries > 10 => return None, | ||
| Ok(result) => return Some(result), | ||
| Err(Ordering::Less) => { | ||
| lo = middle; |
There was a problem hiding this comment.
This may be way off, but should it be lo = middle + 1 to avoid infinite loop in case hi = lo + 1? Same for hi = middle - 1
There was a problem hiding this comment.
You're absolutely right! I guess this proves @nrc's point about binary search being prone to off-by-one errors ;-)
marcusklaas
added a commit
that referenced
this pull request
Sep 7, 2015
Add failure mode to `write_list`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes some cases where we would exceed the column limit.