Use normalized form to format use items #2576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. snake_case < CamelCase < UPPER_SNAKE_CASE 2. Use vertical layout for list with nested imports.
This change is necessary when we remove unused imports (`use std::{};`).
This prevents the trailing `;` on use item to be treated as comment.
This commit implements `Rewrite` trait on `UseTree`, which is a normalized form of `ast::UseTree` for rustfmt.
|
Thank you! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses normalized form of
ast::UseTreeto format them.My apologies for a big commit which makes this hard to review, I tried to separate them in logical way, but failed to do so...
Closes #2531.