change new line point in the case of no args #3294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scampi
approved these changes
Jan 26, 2019
|
@rchaser53 Looks good, thank you for your contribution! However this PR introduces a formatting change to the default, so the change needs to be gated against the format version. Could you add the version gate to the code and test, please? https://github.com/rust-lang/rustfmt/pull/3250/files is a good example of how to do it. |
|
@topecongiro |
|
Thanks! |
|
Thanks @topecongiro I always forget about gating... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related: #3278
I Implemented the first scampi's idea. How is it?