Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP Allow specifying glob pattern to ignore config option #3413

Closed
wants to merge 1 commit into from
Closed

WIP Allow specifying glob pattern to ignore config option #3413

wants to merge 1 commit into from

Conversation

topecongiro
Copy link
Contributor

cc #3243, #3395.

scampi
scampi suggested changes Feb 23, 2019
View reviewed changes
Copy link
Contributor

@scampi scampi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/ignore.rs

use crate::config::{FileName, IgnoreList};

pub struct IgnorePathSet {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you write few words documenting this struct ?

@topecongiro topecongiro changed the title Allow specifying glob pattern to ignore config option WIP Allow specifying glob pattern to ignore config option Feb 25, 2019
@topecongiro
Copy link
Contributor Author

topecongiro commented Mar 5, 2019 •
edited
Loading

  • We should use ignore crate instead

@topecongiro topecongiro mentioned this pull request Mar 31, 2019
Closed
@rchaser53
Copy link
Contributor

I don't have the permission to push to topecongiro:ignore-with-glob. So I create new branch from topecongiro:ignore-with-glob and will send the PR.

@rchaser53 rchaser53 mentioned this pull request Apr 1, 2019
Merged
@topecongiro
Copy link
Contributor Author

Closing in favor of #3488.

@topecongiro topecongiro closed this Apr 9, 2019
@topecongiro topecongiro deleted the ignore-with-glob branch April 9, 2019 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scampi scampi scampi requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@topecongiro @rchaser53 @scampi