Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolves #3665 #3668

Closed
wants to merge 25 commits into from
Closed

resolves #3665 #3668

wants to merge 25 commits into from

Conversation

la10736
Copy link
Contributor

@la10736 la10736 commented Jul 4, 2019

resolves #3665

  • Implementation and test based on rustfmt::skip::macros() feature
  • Refactoring to encapsulate both macros and attributes
  • Removed useless RefCell

@la10736 la10736 changed the title Implement #3665 resolves #3665 Jul 4, 2019
src/attr.rs Outdated Show resolved Hide resolved
src/skip.rs Outdated Show resolved Hide resolved
src/skip.rs Show resolved Hide resolved
src/skip.rs Outdated Show resolved Hide resolved
@scampi
Copy link
Contributor

scampi commented Jul 13, 2019

can you update the changelog file ?

@la10736
Copy link
Contributor Author

la10736 commented Jul 15, 2019

Sorry... I did some craps on rebasing my fork.... Now should be ok.

@scampi
Copy link
Contributor

scampi commented Jul 15, 2019

@la10736 there are few more commits you can drop, e.g., fix print-config minimal option. It's ok to just open a new clean PR ;o)

Michele d'Amico and others added 2 commits July 15, 2019 21:10
- better naming
- `skip` module doc
- update CHANGELOG
- removed useless `*`
@la10736
Copy link
Contributor Author

la10736 commented Jul 15, 2019

Ok I'm closing it

@la10736 la10736 closed this Jul 15, 2019
@la10736
Copy link
Contributor Author

la10736 commented Jul 15, 2019

Ok a fresh new PR at #3689

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Skip Attribute
6 participants