Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add #[ignore] to test that runs external process #3690

Merged
merged 4 commits into from
Jul 16, 2019

Conversation

topecongiro
Copy link
Contributor

@topecongiro topecongiro commented Jul 16, 2019

This PR adds test-binary feature to work around test failures which appears in the rustc repo [1].

This PR adds #[ignore] to test that runs an external process to work around test failures that appears in the rustc repo [1].

[1] rust-lang/rust#62688 (comment)

@topecongiro topecongiro changed the title Add test-binary feature Add #[ignore] to test that runs external process Jul 16, 2019
Copy link
Contributor

@scampi scampi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@topecongiro topecongiro merged commit 66c27c9 into rust-lang:master Jul 16, 2019
@topecongiro topecongiro deleted the test-binary-feature branch July 16, 2019 10:36
la10736 pushed a commit to la10736/rustfmt that referenced this pull request Jul 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants