Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use issue = "none" instead of "0" #3977

Merged
merged 1 commit into from
Dec 26, 2019
Merged

Conversation

JohnTitor
Copy link
Member

Replace issue = "0" with "none"

CC: rust-lang/rust#67496

@topecongiro
Copy link
Contributor

As all occurrences of issue = "0" are limited to test codes that are read-only and not compiled, I think that these are not blocking rust-lang/rust#67496.

I am going to merge this PR anyway, just in case. Thanks!

@topecongiro topecongiro merged commit 5eb06d0 into rust-lang:master Dec 26, 2019
@JohnTitor JohnTitor deleted the issue-none branch December 26, 2019 14:39
@ytmimi
Copy link
Contributor

ytmimi commented Apr 3, 2022

@calebcartwright given that this is just in test code and that the associated issue in the rust-lang repo has been closed I don't think we actually need to backport this. That being said, it's a simple cherry-pick so we could backport this if needed.

@calebcartwright
Copy link
Member

Agreed 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants