add newline when the last line has comment #4019
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rchaser53
commented
Jan 15, 2020
| mod a { | ||
| mod b { | ||
| ///test | ||
| fn foo() -> (){ |
There was a problem hiding this comment.
This bug is caused by the case when the rustfmt fails to format because the width is greater than max_width in rustfmt.toml.
In this case, this line is greater than 10. rustfmt seems to remove the white space and emits the not formatted string. I think that's the reason why the implementation exists after comment on the same line.
There was a problem hiding this comment.
The indentation of foo looks/feels a bit odd 🤔
I feel like we may need a slightly different solution in order to maintain the target indent (since this exceeds the max_width anyway)
|
I don't have enough time, so close this PR. Sorry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #3988