Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix formatting arbitrary extern abi #4088

Merged
merged 2 commits into from
Mar 31, 2020

Conversation

calebcartwright
Copy link
Member

Fixes #4086

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@@ -54,10 +54,6 @@ version = "642.0.0"
package = "rustc-ap-rustc_span"
version = "642.0.0"

[dependencies.rustc_target]
package = "rustc-ap-rustc_target"
version = "642.0.0"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice little bonus here being able to remove a dependency

@calebcartwright
Copy link
Member Author

AppVeyor failure (i686-pc-windows-msvc) was spurious

https://ci.appveyor.com/project/rust-lang-libs/rustfmt/builds/31592940/job/uvjt8utcs2kemj0o

cargo build --verbose
    Updating crates.io index
error: failed to get `anyhow` as a dependency of package `rustfmt-nightly v2.0.0-rc.1 (C:\projects\rustfmt)`
Caused by:
  failed to fetch `https://github.com/rust-lang/crates.io-index`
Caused by:
  error inflating zlib stream; class=Zlib (5)
Command exited with code 101

@topecongiro topecongiro merged commit 4d22687 into rust-lang:master Mar 31, 2020
@calebcartwright calebcartwright deleted the fix_abi_formatting branch March 31, 2020 15:11
@karyon
Copy link
Contributor

karyon commented Oct 26, 2021

backported in #4089

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow arbitrary extern ABI
3 participants