Prune stale issues #4246
Merged
Prune stale issues #4246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds regression tests for the following issues which seem to be fixed on master: Closes rust-lang#1762 Closes rust-lang#2388 Closes rust-lang#2672 Closes rust-lang#2755 Closes rust-lang#2947 Closes rust-lang#2978 Closes rust-lang#3148 Closes rust-lang#3206 @topecongiro @calebcartwright appologies for the large number of issues in this commit; if you prefer I can split it up into 2+.
|
No worries @ayazhafiz, for now this is fine as one PR |
| _ => false, | ||
| }) | ||
| .collect(); | ||
| } |
There was a problem hiding this comment.
Could we also include the snippet from the OP in the referenced iss
let a = b.iter()
.map(|m| {
m.hi()
});| averylongname_asdfffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffdsffffffffffffffffffffffffffffffffffffffffffffffff: i32, | ||
| ) { | ||
| } | ||
| } |
There was a problem hiding this comment.
Could we include the other snippets posted in #2672 (comment) on that thread?
|
Yeah I'll add them in a couple hours
…On Mon, Jun 8, 2020 at 5:54 PM Caleb Cartwright ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In tests/target/issue-2672.rs
<#4246 (comment)>:
> + fn test(
+ shortname: i32,
+ averylongname_asdfffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffdsffffffffffffffffffffffffffffffffffffffffffffffff: i32,
+ ) {
+ }
+
+ let averylongname_asdfffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff =
+ 0;
+}
+
+mod asdf {
+ fn test(
+ averylongname_asdfffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffdsffffffffffffffffffffffffffffffffffffffffffffffff: i32,
+ ) {
+ }
+}
Could we include the other snippets posted in #2672 (comment)
<#2672 (comment)>
on that thread?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#4246 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AE6GL6QDBEINUSTRPN4WQR3RVWB4DANCNFSM4NY42ABA>
.
|
calebcartwright
approved these changes
Jun 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds regression tests for the following issues which seem to be fixed on
master:
Closes #1762
Closes #2388
Closes #2672
Closes #2755
Closes #2947
Closes #2978
Closes #3148
Closes #3206
@topecongiro @calebcartwright appologies for the large number of issues
in this commit; if you prefer I can split it up into 2+.