Skip to content

Ensure that doc url hash IDs are scrolled to on page load #4329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 17, 2020
Merged

Ensure that doc url hash IDs are scrolled to on page load #4329

merged 3 commits into from
Jul 17, 2020

Conversation

ayazhafiz
Copy link
Contributor

topecongiro
topecongiro reviewed Jul 16, 2020
View reviewed changes
Copy link
Contributor

@topecongiro topecongiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR itself LGTM. Would you mind resolving the conflict?

@ayazhafiz
Copy link
Contributor Author

Done

@ayazhafiz ayazhafiz requested a review from topecongiro July 16, 2020 14:29
topecongiro
topecongiro approved these changes Jul 17, 2020
View reviewed changes
Copy link
Contributor

@topecongiro topecongiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@topecongiro topecongiro merged commit 27b54e9 into rust-lang:master Jul 17, 2020
@karyon
Copy link
Contributor

karyon commented Oct 26, 2021

backported in #4958

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@topecongiro topecongiro topecongiro approved these changes

Assignees
No one assigned
Labels
1x-backport:completed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ayazhafiz @karyon @topecongiro